Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codecov-action in place of manual upload #213

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

matt-graham
Copy link
Collaborator

Would resolve #211

Will require a repository secret CODECOV_TOKEN to be added with a Codecov repository upload token set to work.

@matt-graham matt-graham marked this pull request as draft September 16, 2024 15:47
@matt-graham matt-graham added the infrastructure Issues related to infrastructure for repository and project label Oct 8, 2024
@matt-graham matt-graham marked this pull request as ready for review October 23, 2024 13:04
@matt-graham
Copy link
Collaborator Author

Repository secret with Codecov API token now set up (I also regenerated token so current workflow will probably fail until this is in) and I've rebased on main

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (11f76bf) to head (977e104).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          29       29           
  Lines        3319     3319           
=======================================
  Hits         3189     3189           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CosmoMatt CosmoMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, good to get this hidden in secrets as it otherwise is technically a security risk.

@matt-graham matt-graham merged commit 57c07e5 into main Nov 11, 2024
4 checks passed
@matt-graham matt-graham deleted the mmg/update-codecov-action branch November 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to infrastructure for repository and project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov API token exposed in workflow file
2 participants