feat(sequencer)!: update to ABCI v0.38 #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ria into noot/sequencer-0.38
…ria into noot/sequencer-0.38
Fraser999
approved these changes
Apr 12, 2024
Fraser999
reviewed
Apr 15, 2024
SuperFluffy
reviewed
Apr 16, 2024
| penumbra-ibc = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.69.1", default-features = false } | ||
| penumbra-proto = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.69.1" } | ||
| penumbra-tower-trace = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.69.1" } | ||
| # update once https://github.com/penumbra-zone/penumbra/commit/8b06546af43bf073fd99f3f9d82b8afb51872489 makes it into a release |
There was a problem hiding this comment.
Let's have a tracking issue for this?
| tower-actor = "0.1.0" | ||
| cnidarium = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.69.1" } | ||
| cnidarium-component = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.69.1" } | ||
| cnidarium = { git = "https://github.com/penumbra-zone/penumbra.git", rev = "8b06546af43bf073fd99f3f9d82b8afb51872489" } |
There was a problem hiding this comment.
Same as for the penumbra deps, right? Let's add this to a tracking issue
| evidence_hash: Some(Hash::default()), // unused | ||
| height: finalize_block.height, | ||
| last_block_id: None, // unused | ||
| last_commit_hash: Some(Hash::default()), // unused |
There was a problem hiding this comment.
Turns out, this is just: Some(Hash::default()) -> Some(Hash::None)
github-actions
bot
added
conductor
Fraser999
approved these changes
Apr 17, 2024
SuperFluffy
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updates the sequencer app to use ABCI v0.38, which replaces
begin_block/deliver_tx/end_blockwith one call,finalize_block.relevant penumbra PRs:
commit(done in cnidarium: implement deferred commits viaStagedWriteBatchpenumbra-zone/penumbra#4122)Background
this was inevitable, also it cleans up the block execution flow inside the sequencer application. (removed
processed_txsandcurrent_sequencer_block_builderfrom the app)Changes
finalize_block; for the most part, I left thebegin_block/deliver_tx/end_blockas they are but called them insidefinalize_blockSequencerBlockat the end offinalize_blockwithout needing to track things between callsTesting
unit tests
ran it with cometbft release v0.38.6
Breaking Changelist
Related Issues
closes #679