Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use bollard client for Image builds #139

Closed
wants to merge 1 commit into from
Closed

refactor: Use bollard client for Image builds #139

wants to merge 1 commit into from

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Nov 3, 2024

Resolves: #129

Work Done

  • Use bollard API instead of unix cmds

@akhercha akhercha self-assigned this Nov 3, 2024
@akhercha akhercha changed the title dev: Use bollard client for Image builds refactor: Use bollard client for Image builds Nov 3, 2024
@akhercha
Copy link
Member Author

akhercha commented Nov 3, 2024 •
edited
Loading

Tested & not worth it - need to compress the whole folder using tar so Bollard can use the context & perfs are not so much better.

@akhercha akhercha closed this Nov 3, 2024
@akhercha akhercha deleted the dev/use_bollard branch December 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akhercha akhercha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: Use bollard to build local docker image in tests
1 participant
@akhercha