Implement aggregation hook #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, can you comment Issue #51, so I can assign you ? Thanks ! |
remybar
force-pushed
the
feat-aggregation_hook
branch
from
246a8ea to
1120410
Compare
JordyRo1
reviewed
Jun 27, 2024
| } | ||
|
|
||
| #[constructor] | ||
| fn constructor(ref self: ContractState, hooks: Span<ContractAddress>) { |
There was a problem hiding this comment.
Hooks are not meant to be defined in the constructor but retrieved from the metadata. But this might be a little tricky, so I can handle it if necessary
JordyRo1
reviewed
Jun 27, 2024
| let hook_count = self.hook_count.read(); | ||
| let mut i = 0_usize; | ||
| loop { | ||
| if i >= hook_count { |
There was a problem hiding this comment.
To be applied to hooks defined in metadata.
JordyRo1
reviewed
Jun 27, 2024
remybar
force-pushed
the
feat-aggregation_hook
branch
from
1120410 to
b479967
Compare
|
Hi @JordyRo1 ! Any news about this PR ? Should I change something or is it fine to be merged ? This PR was done in the context of OD Hack 5 and the OD Hack 9 has just finished ... 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #51.