Don't preserve tar mtime to work around tar-rs bug. #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
approved these changes
Dec 13, 2023
charliermarsh
force-pushed
the
dont-preserve-tar-mtime
branch
from
aa6a257 to
d39d603
Compare
Don't preserve mtime to work around alexcrichton/tar-rs#349 to fix #579.
|
Thank you! |
konstin
added a commit
that referenced
this pull request
Feb 20, 2024
Don't preserve mtime to work around alexcrichton/tar-rs#349. Same as #634 except for the streaming unzip. Fixes #1748.
charliermarsh
pushed a commit
that referenced
this pull request
Feb 20, 2024
## Summary Don't preserve mtime to work around alexcrichton/tar-rs#349. Same as #634 except for the streaming unzip. Fixes #1748. ## Test Plan Added the tomli source dist as test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't preserve mtime to work around alexcrichton/tar-rs#349 to fix #579.