Stream unpacking of source distribution downloads #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/async-zip
branch
from
8709d74 to
5768543
Compare
charliermarsh
force-pushed
the
charlie/async-zip
branch
from
5768543 to
79d643d
Compare
konstin
reviewed
Jan 29, 2024
| @@ -19,6 +19,9 @@ license = "MIT OR Apache-2.0" | |||
| [workspace.dependencies] | |||
| anstream = { version = "0.6.5" } | |||
| anyhow = { version = "1.0.79" } | |||
| async-compression = { version = "0.4.6" } | |||
| async-std = {version = "1.6.0" } | |||
There was a problem hiding this comment.
I'm a bit worried about the async-std dep, it's abandoned and could clash with tokio(?)
There was a problem hiding this comment.
What is your source for async-std being abandoned?
There was a problem hiding this comment.
I can migrate to https://crates.io/crates/tokio-tar which is a fork for Tokio. Or I can look into forking async-tar to land this PR: dignifiedquire/async-tar#41.
There was a problem hiding this comment.
There is no official message or anything, there's just barely any activity on the repo anymore
As long as it's stable it's fine, i'm more worried we'll get some clash with tokio or something because they are different executors with different runtimes and types.
charliermarsh
added a commit
that referenced
this pull request
Jan 29, 2024
## Summary `tokio_tar` is a fork of `async_tar` that uses Tokio instead of `async-std`. Using it removes a significant dependency from our tree. (There is an open PR (dignifiedquire/async-tar#41) in `async-tar` to add Tokio support, but it's over a year old.) See: #1157 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates our source distribution downloads to unzip as we stream, similar to our approach for wheels.
In my testing, this showed a consistent speedup (e.g., 6% here for a few representative source distributions):