This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement global shortcuts #393
Implement global shortcuts #393
Changes from 3 commits
1afa8f5
1f1b5ca
2d21475
7773575
75762cc
bff74b8
a47d53a
35cffd4
6b0bc39
985de79
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could your remove this empty line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of making the Global Shortcut methods/variables global to the package, could you:
GlobalShortcuts
struct that will contain the*object
and registered callbacksglobalShortcuts *GlobalShortcuts
variable to theAstilectron
structnewGlobalShortcuts()
method that creates a*GlobalShortcuts
(and does the other instantiating stuff that your InitGlobalShortcuts() does) and call this method after creating the dockGlobalShortcuts()
method to theAstilectron
struct that will returna.globalShortcuts
Register()
,IsRegistered()
,Unregister()
andUnregisterAll()
methods to theGlobalShortcuts
structThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using
GlobalShortcut
directly here, could you:EventGlobalShortcuts
struct containing json fields only?GlobalShortcuts
s
at the end of allglobal shortcut
occurencesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename the file to
global_shortcuts.go
?