This repository has been archived by the owner on Dec 29, 2021. It is now read-only.
Add ability to set current_dir #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! Can you rebase this on master now that #24 has landed? |
|
btw this is how I resolved the unused_doc issues in another project |
|
Heh, thanks for the tip. Maybe updating error-chain would help as well ;)
Ed Page <[email protected]> schrieb am Fr. 8. Sep. 2017 um 15:18:
… btw this is how I resolved the unused_doc issues in another project
***@***.***
<cobalt-org/cobalt.rs@bd5d3b7>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOX4PkjfMfiQ7APLPLnx1LL0swP8W1ks5sgT6PgaJpZM4PQpAL>
.
|
|
Thanks for this whole batch of PRs! I'm at a conference currently, so I'm only now able to review it. Looks great, though! bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 11, 2017
33: Add ability to set current_dir r=killercup a=epage Some tests need to run in certain directories but if you call `std::env::set_current_dir` within your test, you can hit race conditions with other tests running at the same time. This allows you to set the current_dir only on the child process.
Timed out |
|
bors r+
bors[bot] <[email protected]> schrieb am Mo. 11. Sep. 2017 um 12:20:
… Timed out
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOX_RzR0OXENc7bht1-kskU5_hrujEks5shQmAgaJpZM4PQpAL>
.
|
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Sep 11, 2017
33: Add ability to set current_dir r=killercup a=epage Some tests need to run in certain directories but if you call `std::env::set_current_dir` within your test, you can hit race conditions with other tests running at the same time. This allows you to set the current_dir only on the child process.
Timed out |
|
Weird. How did it ever work before? Anyway, I'll try to fix it later when I
have some time
Michael Howell <[email protected]> schrieb am Mo. 11. Sep. 2017 um
19:01:
… You should probably allow Travis to build the staging branch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOX8A6iZ3boWYwl63jd3sb6MXIWBYtks5shWdkgaJpZM4PQpAL>
.
|
|
Okay, let's give it another try! bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 13, 2017
33: Add ability to set current_dir r=killercup a=epage Some tests need to run in certain directories but if you call `std::env::set_current_dir` within your test, you can hit race conditions with other tests running at the same time. This allows you to set the current_dir only on the child process.
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests need to run in certain directories but if you call
std::env::set_current_dirwithin your test, you can hit race conditions with other tests running at the same time. This allows you to set the current_dir only on the child process.