Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix params not defined optional in apidoc #28

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix params not defined optional in apidoc #28

merged 1 commit into from
Oct 25, 2024

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Oct 24, 2024

  • Fix parameters not defined as optional in apidoc for /api/v3/groups/:groupId/members endpoint
  • Fix parameter not defined as optional in apidoc for /api/v3/user/class/cast/:spellId endpoint

@asmfreak
Copy link
Owner

Thank you for your work here and on HA. I'd prefer if you would bring this fix to Habitica's source (and/or check it is fixed in it). I'd merge this once you'd check that and/or send them a PR (even if they don't merge PR).

@asmfreak asmfreak assigned asmfreak and tr4nt0r and unassigned asmfreak Oct 25, 2024
@tr4nt0r
Copy link
Contributor Author

tr4nt0r commented Oct 25, 2024

HabitRPG/habitica#15351

@asmfreak
Copy link
Owner

Thanks!

@asmfreak asmfreak merged commit ae70532 into asmfreak:master Oct 25, 2024
@tr4nt0r tr4nt0r deleted the fix_optional_params branch October 25, 2024 14:51
@tr4nt0r
Copy link
Contributor Author

tr4nt0r commented Oct 25, 2024

Thanks for merging so fast. Would appreciate it if you could also make a new release on pypi 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tr4nt0r tr4nt0r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tr4nt0r @asmfreak