Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update /market command #9

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Update /market command #9

merged 8 commits into from
Oct 18, 2023

Conversation

igprad
Copy link
Collaborator

@igprad igprad commented Oct 18, 2023

Changelog

  • Fix call to quickchart and getting successful response.
  • Change /market option by removing days since there's data limitation that can be requested to quickchart.

What can be improve

  • Another 3rd party option for chart ?
  • There's limitation for how many data requested for the chart. (Getting max 250 data)
  • Update chart design
  • Improve labels

image

@heronimus
Copy link
Member

LGTM!
this update is awesome, thanks @igprad !

@heronimus heronimus merged commit 51b1467 into asiantbd:main Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heronimus heronimus heronimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igprad @heronimus