Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to merge logic #9

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

zachdaniel
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel
Copy link
Contributor Author

@pinetops In an effort not to lose your work, this PR is made with your original commit retained :)

Now, we can modify ash and reactor to have merge_with: [Reactor.Error] and merge_with: [Ash.Error] respectively, and this should have the behavior you want.

I did add some flattening logic, but I think what I've added is a bit simpler overall, and only has to happen when an error class is produced.

@pinetops
Copy link

Wonderful. Thankyou!

@zachdaniel zachdaniel merged commit 906a82e into main May 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants