fix: pass dot_formatter when updating rewrite sources #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachallaun
commented
Nov 5, 2024
Comment on lines
-589
to
+590
| |> Rewrite.Source.update(:file_creator, :content, contents)} | ||
| |> update_source(igniter, :content, contents, by: :file_creator)} |
There was a problem hiding this comment.
I believe the previous call format was already incorrect and should have been by: :file_creator -- something that slipped by in the update to Rewrite 1.0?
The next change is the same.
zachallaun
commented
Nov 5, 2024
Comment on lines
+21
to
+22
| |> Igniter.Project.Deps.add_dep({:mimic, "~> 1.7"}) | ||
| |> Igniter.Project.Formatter.import_dep(:mimic) |
There was a problem hiding this comment.
This is a little hacky, but I needed a dep we already had that exports some locals_without_parens, and Mimic was the one I found.
|
@zachallaun confirmed it's working as expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
I'd like to wait for @leandrocp to confirm that this branch works for him before merging 👍
Contributor checklist