Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR-5790 Add CORS preflight OPTIONS request #803

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

reweeden
Copy link
Contributor

@reweeden reweeden commented Mar 19, 2024

Some libraries will automatically make this OPTIONS request and we need to respond with the appropriate headers to prevent cross origin requests from being blocked.

@reweeden reweeden force-pushed the rew/pr-5790-preflight-cors branch 2 times, most recently from f47ea3b to e961c0f Compare March 19, 2024 21:03
@reweeden reweeden force-pushed the rew/pr-5790-preflight-cors branch from e961c0f to f1162ab Compare March 21, 2024 17:01
@reweeden reweeden force-pushed the rew/pr-5790-preflight-cors branch from f1162ab to e924b5e Compare March 21, 2024 20:28
@reweeden reweeden marked this pull request as ready for review March 21, 2024 21:29
Copy link
Contributor

@mattp0 mattp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That was pretty quick and not too many changes.

Should we be concerned about the decrease in code cov here? Seems like there could be some easy unit tests added.

@reweeden reweeden force-pushed the rew/pr-5790-preflight-cors branch from e924b5e to 5b35486 Compare March 22, 2024 15:53
@reweeden
Copy link
Contributor Author

Yea I just added a some unit tests.

@reweeden reweeden merged commit c9da3ff into devel Mar 22, 2024
14 of 15 checks passed
@reweeden reweeden deleted the rew/pr-5790-preflight-cors branch March 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants