PR-5069 Refactor locate endpoint #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattp0
approved these changes
Dec 20, 2023
mckadesorensen
approved these changes
Dec 20, 2023
|
@reweeden It is failing an automatic check. |
gjclark
approved these changes
Dec 20, 2023
It's pyup complaining about a dependency. I'm going to ignore it for 2 reasons:
|
reweeden
force-pushed
the
rew/pr-5069-refactor-locate
branch
from
5b67219 to
2c94fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/locateendpoint seems to be the last place that had special handling code to interact with the bucket map that was not going through theBucketMapclass. This change will ensure that the bucket map behavior is consistent for/locateand other functionality. Specifically, this allows the old-style bucket maps with no top levelMAPkey to work with/locate(previously a 500 error would be returned).