Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept A-api-request-uuid and add it to presigned when available #292

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Accept A-api-request-uuid and add it to presigned when available #292

merged 3 commits into from
Apr 17, 2024

Conversation

jeffersonwhite
Copy link
Contributor

No description provided.

@jeffersonwhite jeffersonwhite changed the title Accept api_request_uuid and add it to presigned when available Accept A-api-request-uuid and add it to presigned when available Apr 12, 2024
@jeffersonwhite
Copy link
Contributor Author

There's also a corresponding change in TEA:
asfadmin/thin-egress-app#807

mattp0
mattp0 previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@mattp0 mattp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge rain-api-core then the TEA PR.

@jeffersonwhite
Copy link
Contributor Author

@mattp0 @reweeden The failure in the code coverage test looks to be unrelated, thoughts on what to do? Can we retrigger the test?

@mattp0 mattp0 merged commit a9a00d1 into asfadmin:master Apr 17, 2024
4 of 5 checks passed
@mattp0
Copy link
Contributor

mattp0 commented Apr 17, 2024

@mattp0 @reweeden The failure in the code coverage test looks to be unrelated, thoughts on what to do? Can we retrigger the test?

Its failing on the last step of the code cov reporter, I am going to merge this and we will take care of the code cov reporting action issue.

@reweeden
Copy link
Contributor

I attempted to retrigger it multiple times and it failed every time. Not sure what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reweeden reweeden reweeden approved these changes

@mattp0 mattp0 mattp0 approved these changes

@mckadesorensen mckadesorensen Awaiting requested review from mckadesorensen

@gjclark gjclark Awaiting requested review from gjclark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffersonwhite @mattp0 @reweeden