On demand search bugfixes

src/app/components/results-menu/scenes-list/scenes-list.component.ts

@@ -500,6 +500,7 @@ export class ScenesListComponent implements OnInit, OnDestroy, AfterContentInit
   }
 
   private loadDummyProducts(scenes: CMRProduct[]) {
+
     const scenesToLoad = scenes
     .slice(0, this.numberProductsInList)
     .filter(s => s.isDummyProduct)

src/app/services/hyp3.service.ts

@@ -118,6 +118,10 @@ export class Hyp3Service {
         jobOptions.name = options.projectName;
       }
 
+      if (!jobOptions.name) {
+        delete jobOptions.name;
+      }
+
       return jobOptions;
     });
   }

src/app/store/scenes/scenes.reducer.ts

@@ -66,7 +66,8 @@ export const initState: ScenesState = {
 export function scenesReducer(state = initState, action: ScenesActions): ScenesState {
   switch (action.type) {
     case ScenesActionType.SET_SCENES: {
-      let subproducts: CMRProduct[] = []
+      let subproducts: CMRProduct[] = [];
+
       let searchResults = action.payload.products.map(p =>
         p.metadata.productType === 'BURST' ? ({
           ...p,
@@ -91,6 +92,12 @@ export function scenesReducer(state = initState, action: ScenesActions): ScenesS
 
       const products = searchResults
       .reduce((total, product) => {
+        if (product.isDummyProduct && isAlreadyLoaded(product, state.products[product.id])) {
+          total[product.id] = state.products[product.id];
+
+          return total;
+        }
+
         total[product.id] = product;
 
         return total;
@@ -111,14 +118,14 @@ export function scenesReducer(state = initState, action: ScenesActions): ScenesS
             groupCriteria = product.id;
           }
         }
+
         const scene = total[groupCriteria] || [];
 
         total[groupCriteria] = [...scene, product.id];
         return total;
       }, {});
 
       for (const [groupId, productNames] of Object.entries(productGroups)) {
-
         (<string[]>productNames).sort(
           (a, b) => products[a].bytes - products[b].bytes
         ).reverse();
@@ -152,10 +159,13 @@ export function scenesReducer(state = initState, action: ScenesActions): ScenesS
         const product  = cmrData[jobProduct.name];
 
         if(!!product) {
+          if (!jobProduct.metadata.job) {
+            return;
+          }
           let job = {
             ...jobProduct.metadata.job,
             job_parameters: {
-              ...jobProduct.metadata.job.job_parameters,
+              ...jobProduct.metadata.job?.job_parameters,
             }
           };
           const jobFile = !!job.files ?
@@ -177,6 +187,7 @@ export function scenesReducer(state = initState, action: ScenesActions): ScenesS
             bytes: jobFile.size,
             groupId: job.job_id,
             id: job.job_id,
+            isDummyProduct: false,
             metadata: {
               ...product.metadata,
               fileName: jobFile.filename || '',
@@ -567,6 +578,10 @@ const productsForScene = (selected, state) => {
     }).reverse();
 };
 
+const isAlreadyLoaded = (product, oldProduct) => {
+  return !!oldProduct && !oldProduct.isDummyProduct && product.isDummyProduct;
+}
+
 export const getAreProductsLoaded = createSelector(
   getScenes,
   state => state.length > 0

src/app/store/search/search.effect.ts

@@ -372,18 +372,18 @@ export class SearchEffects {
     const jobs = jobsRes.hyp3Jobs;
 
     const granuleNames = this.getAllGranulesFromJobs(jobs);
-    const asfApiListQuery = this.dummyProducts$(granuleNames);
+    const fakeApiListQuery = this.dummyProducts$(granuleNames);
 
-    return asfApiListQuery.pipe(
-      map(products => {
-        return products
+    return fakeApiListQuery.pipe(
+      map(dummyProducts => {
+        return dummyProducts
           .reduce((prodsByName, p) => {
             prodsByName[p.name] = p;
             return prodsByName;
           }, {});
       }),
-      map(products => {
-        return this.hyp3JobToProducts(jobs, products);
+      map(dummyProducts => {
+        return this.hyp3JobToProducts(jobs, dummyProducts);
       }),
       withLatestFrom(this.store$.select(getIsCanceled)),
       map(([products, isCanceled]) =>