Merge pull request #14808 from artsy/review-app-preload

fix(early-hints): Fix cors configuration around preloading js assets
artsy · Nov 6, 2024 · 8ec8df6 · 8ec8df6
2 parents 4d6f44a + 7314c08
commit 8ec8df6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/src/Server/__tests__/getWebpackEarlyHints.jest.ts b/src/Server/__tests__/getWebpackEarlyHints.jest.ts
@@ -24,12 +24,12 @@ describe("getWebpackEarlyHints", () => {
 
     expect(fs.readFileSync).toHaveBeenCalledWith(HINTS_PATH, "utf-8")
     expect(result.linkHeaders).toEqual([
-      `<https://cdn.example.com/chunk1.js>; rel=preload; as=script; crossorigin`,
-      `<https://cdn.example.com/chunk2.js>; rel=preload; as=script; crossorigin`,
+      `<https://cdn.example.com/chunk1.js>; rel=preload; as=script`,
+      `<https://cdn.example.com/chunk2.js>; rel=preload; as=script`,
     ])
     expect(result.linkPreloadTags).toEqual([
-      `<link rel="preload" as="script" href="https://cdn.example.com/chunk1.js" crossorigin>`,
-      `<link rel="preload" as="script" href="https://cdn.example.com/chunk2.js" crossorigin>`,
+      `<link rel="preload" as="script" href="https://cdn.example.com/chunk1.js">`,
+      `<link rel="preload" as="script" href="https://cdn.example.com/chunk2.js">`,
     ])
   })
 
@@ -43,12 +43,12 @@ describe("getWebpackEarlyHints", () => {
 
     expect(fs.readFileSync).toHaveBeenCalledWith(HINTS_PATH, "utf-8")
     expect(result.linkHeaders).toEqual([
-      `</chunk1.js>; rel=preload; as=script; crossorigin`,
-      `</chunk2.js>; rel=preload; as=script; crossorigin`,
+      `</chunk1.js>; rel=preload; as=script`,
+      `</chunk2.js>; rel=preload; as=script`,
     ])
     expect(result.linkPreloadTags).toEqual([
-      `<link rel="preload" as="script" href="/chunk1.js" crossorigin>`,
-      `<link rel="preload" as="script" href="/chunk2.js" crossorigin>`,
+      `<link rel="preload" as="script" href="/chunk1.js">`,
+      `<link rel="preload" as="script" href="/chunk2.js">`,
     ])
   })
 })
diff --git a/src/Server/getWebpackEarlyHints.ts b/src/Server/getWebpackEarlyHints.ts
@@ -34,11 +34,9 @@ export const getWebpackEarlyHints = (): {
 
   const links = chunkFiles.reduce(
     (acc, file) => {
-      acc.linkHeaders.push(
-        `<${cdnUrl}${file}>; rel=preload; as=script; crossorigin`
-      )
+      acc.linkHeaders.push(`<${cdnUrl}${file}>; rel=preload; as=script`)
       acc.linkPreloadTags.push(
-        `<link rel="preload" as="script" href="${cdnUrl}${file}" crossorigin>`
+        `<link rel="preload" as="script" href="${cdnUrl}${file}">`
       )
       return acc
     },