Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): enable artist series suggestions #9663

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

anandaroop
Copy link
Member

@anandaroop anandaroop commented Dec 14, 2023

This PR resolves ONYX-566

Description

Enables the fetching and display of suggested Artist Series criteria, and puts it behind a new AREnableArtistSeriesSuggestions flag

(This is the replacement for #9631)

With the feature enabled…

series-eigen

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Enables suggested Artist Series criteria in the Alerts flow, behind feature flag - roop

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

olerichter00
olerichter00 previously approved these changes Dec 14, 2023
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Dec 14, 2023

This PR contains the following changes:

  • Cross-platform user-facing changes (Enables suggested Artist Series criteria in the Alerts flow, behind feature flag - roop)

Generated by 🚫 dangerJS against e8b5abb

@anandaroop
Copy link
Member Author

Tests are green now, going to go ahead and merge to get this in for the next code freeze. (It is disabled via Echo for now)

@anandaroop anandaroop merged commit 16e076c into main Dec 14, 2023
7 checks passed
@anandaroop anandaroop deleted the anandaroop/ONYX-566-suggest-series-from-artwork branch December 14, 2023 20:19
anandaroop added a commit to artsy/echo that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants