chore(performance): sentry performance updates #11212
Open
+7
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainbicycle
commented
Nov 28, 2024
| context.sampled = false | ||
| } | ||
| return context | ||
| }, |
There was a problem hiding this comment.
this was there to make names in perf dashboard more reasonable, but no longer necessary since nav refactor!
brainbicycle
commented
Nov 28, 2024
| import { appJson } from "app/utils/jsonFiles" | ||
| import { Platform } from "react-native" | ||
| import Config from "react-native-config" | ||
| import DeviceInfo from "react-native-device-info" | ||
|
|
||
| export const routingInstrumentation = new Sentry.ReactNavigationInstrumentation({ |
brainbicycle
commented
Nov 28, 2024
| @@ -214,6 +215,8 @@ export const SearchScreen: React.FC<SearchScreenProps> = () => { | |||
| ) | |||
| } | |||
|
|
|||
| export const SearchScreen = withProfiler(SearchScreenInner, { name: "Search" }) | |||
There was a problem hiding this comment.
we can use this to get more in depth flamegraph style profiles of a given screen: https://artsynet.sentry.io/profiling/profile/eigen/a7bb035f850d44f7a9dc1f2a5274e3c7/flamegraph/?colorCoding=by%20system%20vs%20application%20frame&fov=0%2C0%2C2658378240%2C31&query=&sorting=call%20order&tid=4048240&view=top%20down
hoping it will be cleaner with a real build with sourcemaps but let's see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Some follow-ups now that our navigation is not quite as weird!
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.