Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dismiss keyboard before opening sort and filter modal #11210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: dismiss keyboard before opening sort and filter modal #11210

wants to merge 1 commit into from
+5 −1

Conversation

MounirDhahri
Copy link
Member

Description

This PR is an attempt to fix the sort and filter transition in the new search modal.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a [feature flag], or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an [app state migration], or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

#nochangelog

@MounirDhahri MounirDhahri self-assigned this Nov 27, 2024
@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

✅ No changelog changes

Generated by 🚫 dangerJS against ce4b89d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MounirDhahri MounirDhahri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MounirDhahri @ArtsyOpenSource