chore: Upgrade to sentry-ruby, rails, sidekiq sdks, removes sentry-raven #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpotts244
commented
Nov 22, 2024
| config.dsn = Convection.config.sentry_dsn if Convection.config.sentry_dsn | ||
| config.processors -= [Raven::Processor::PostData] |
There was a problem hiding this comment.
If Im reading the migration docs right, I think this is OK to remove as these processors are no longer used in the sdk and there's default data scrubbing behaviors
https://docs.sentry.io/platforms/ruby/migration/#removed-processors
jpotts244
commented
Nov 22, 2024
| Raven.user_context(id: @current_user) | ||
| def set_sentry_context | ||
| # Heads up! @current_user is the user's id as a string not an object | ||
| Sentry.set_user(user_id: @current_user) | ||
| end |
There was a problem hiding this comment.
Didnt want to mess with @current_user at this time - it is used everywhere
and its technically a STRING and not an object - bit of a gotcha when I was testing
leamotta
approved these changes
Nov 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to get us off of deprecated
sentry-ravengem, installssentry-ruby,sentry-rails,sentry-sidekiq