Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow multiple uses of injector module in a single python process #84

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: allow multiple uses of injector module in a single python process #84

merged 1 commit into from
Nov 23, 2023

Conversation

danielknell
Copy link
Member

Fixes #83

Description

Removes superfluous calls to binder.bind() that was causing a crash when the module was used a second time.

Motivation and Context

Fixes an unforeseen error case with the injector integration.

How Has This Been Tested?

Additional unit tests were added and manual poking.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danielknell danielknell enabled auto-merge (squash) November 23, 2023 17:22
@danielknell danielknell force-pushed the issue-83 branch 3 times, most recently from 404e70b to 73c9d53 Compare November 23, 2023 17:29
@danielknell danielknell merged commit 759995d into main Nov 23, 2023
1 check passed
@danielknell danielknell deleted the issue-83 branch November 23, 2023 17:34
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: injector module breaks when used a second time.
1 participant
@danielknell