Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add return type for queries #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add return type for queries #100

wants to merge 1 commit into from

Conversation

danielknell
Copy link
Member

@danielknell danielknell commented Aug 9, 2024

Description

Adds a generic Query type that can be extended to define the return type of dispatching the query.

Fixes #99

Motivation and Context

The current Any response has a type does not allow static analysis of the returned value.

How Has This Been Tested?

Manually tested with mypy and vscode type inference (pyright) to check desired type is infered, defaulting to Any.

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: typed query return types
1 participant