Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock prettier version #78

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Lock prettier version #78

merged 2 commits into from
Jun 5, 2024

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Jun 5, 2024

Lock to prettier 3.2.5 due to regression in markdown formatting in 3.3.0: prettier/prettier#16351.

This regression combined with the lack of lockfile in this repository caused the weekly CI run to fail today.

To lock prettier, this commit also adds the requisite node infra:

  • Pin latest LTS version in local dev and CI
  • Update Rakefile to invoke prettier via npm run script
  • Poll for npm dependency updates with dependabot
  • Add node_modules and friends to .gitignore

Failed build is here: https://github.com/artichoke/posix-space/actions/runs/9375863869/job/25814771310

Lock to prettier 3.2.5 due to regression in markdown formatting in
3.3.0: prettier/prettier#16351.

This regression combined with the lack of lockfile in this repository
caused the weekly CI run to fail today.

To lock prettier, this commit also adds the requisite node infra:

- Pin latest LTS version in local dev and CI
- Update `Rakefile` to invoke prettier via npm run script
- Poll for npm dependency updates with dependabot
- Add `node_modules` and friends to `.gitignore`
@lopopolo lopopolo added A-build Area: CI build infrastructure. A-deps Area: Source and library dependencies. labels Jun 5, 2024
@lopopolo lopopolo merged commit 297cc13 into trunk Jun 5, 2024
13 checks passed
@lopopolo lopopolo deleted the lopopolo/lock-prettier branch June 5, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: CI build infrastructure. A-deps Area: Source and library dependencies.
Development

Successfully merging this pull request may close these issues.

1 participant