Format messages more like the Star Wars opening crawl #14
Conversation
The subject line is all caps, centered. Body text is justified. When looking at more verbose commit logs, this simulates the Star Wars experience fairly well. Subject-only commit messages still look okay (if a bit shouty).
|
Hey, just curious - have you had a chance to look at this? |
|
Hey Nate, Sorry for not coming back on this - I've simply forgotten about this pr. Well done for acting as notifier. Seriously. So. I've just looked at the change and I must say I don't like it. For one reason: currently commits are obviously grouped in paragraphs, whereas in your version formatting is more sophisticated and in some cases (long messages maybe?) it does not look nice (I run it through rails/rails) |
|
No problem on the wait - I thought maybe it had slipped through the cracks. I took a look at rails/rails on starlogs.net and on my local copy, and I'm not sure what specifically you dislike about mine. Is it the wrapping of that first line? I had been testing my changes on some of my own repos that follow this recommended format fairly rigorously. Commit messages with one long first line, like a lot of the ones in rails/rails seem to do, don't look very good, it's true. I also noticed that messages with single line breaks separating lines are formatted poorly, which may also have been bothering you. If I found fixes for those bits of ugliness, would you merge this? Or are you saying that you just want to keep the current style of formatting, rather than getting it closer to the original Star Wars look? Either way's fine - it's your repo, and I have mine to work with. Just curious. |
|
If it looks better than current version than I'll be happy to merge your changes. This is of course largely a matter of taste (my taste in this case), but there you go :) |
The subject line is all caps, centered.
Body text is justified.
When looking at more verbose commit logs, this simulates the Star Wars
experience fairly well, my limited testing found.
Subject-only commit messages still look okay (if a bit shouty).
(This is an improvement on an early approach that you may remember - it got reverted due to making single-line commit messages look ugly.
I have a project whose logs I want to read through for nostalgia's sake, so I decided to try hacking on this a bit more, and thought you might be interested in the result.)