Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline local filesystem: x permission on folders #227

Closed
wants to merge 2 commits into from
Closed

Pipeline local filesystem: x permission on folders #227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aecbbfc
Pipeline local filesystem: x permission on folders
remileduc Aug 9, 2017
1d7c6bb
restrictive permission for other users
remileduc Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions storage_service/locations/models/space.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ def move_rsync(self, source, destination, try_mv_local=False):

# Rsync file over
# TODO Do this asyncronously, with restarting failed attempts
command = ['rsync', '-t', '-O', '--protect-args', '-vv', '--chmod=ugo+rw', '-r', source, destination]
command = ['rsync', '-t', '-O', '--protect-args', '-vv', '--chmod=F660,D770', '-r', source, destination]
LOGGER.info("rsync command: %s", command)

p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
Expand Down Expand Up @@ -513,7 +513,7 @@ def create_rsync_directory(self, destination_path, user, host):
for directory in directories:
path = os.path.join(os.path.dirname(directory), '')
path = "{}@{}:{}".format(user, host, utils.coerce_str(path))
cmd = ['rsync', '-vv', '--protect-args', '--chmod=ugo+rw', '--recursive', temp_dir, path]
cmd = ['rsync', '-vv', '--protect-args', '--chmod=ug=rwx,o=rx', '--recursive', temp_dir, path]
LOGGER.info("rsync path creation command: %s", cmd)
try:
subprocess.check_call(cmd)
Expand Down