Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for Write-Only Replica Staging and create_aip_replicas command #48

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Add docs for Write-Only Replica Staging and create_aip_replicas command #48

merged 1 commit into from
Jul 19, 2021

Conversation

tw4l
Copy link
Contributor

@tw4l tw4l commented Jun 8, 2021

@tw4l tw4l requested review from sarah-mason and scollazo June 8, 2021 18:50
sarah-mason
sarah-mason requested changes Jun 14, 2021
View reviewed changes
Copy link

@sarah-mason sarah-mason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Makes sense and I only have to tiny changes to make.

administrators.rst Outdated Show resolved Hide resolved
administrators.rst Outdated Show resolved Hide resolved
@tw4l tw4l force-pushed the dev/issue-1440-offline-replica-space branch from 013cbee to bb24a8d Compare June 14, 2021 19:12
@tw4l tw4l requested a review from sarah-mason June 14, 2021 19:13
@tw4l
Copy link
Contributor Author

tw4l commented Jun 14, 2021

Thanks @sarah-mason! The requested changes have been made and I added a note about the flat storage structure for this space.

@sromkey
Copy link
Contributor

sromkey commented Jul 2, 2021

Just a reminder to merge :)

@tw4l
Copy link
Contributor Author

tw4l commented Jul 5, 2021

@sarah-mason friendly reminder to re-review :) thanks!

sarah-mason
sarah-mason approved these changes Jul 19, 2021
View reviewed changes
Copy link

@sarah-mason sarah-mason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to re-review @tw4l! I must have missed the notification. Looks great though!

@tw4l
Add docs for Write-Only Replica Staging space
8daf752 
Also includes new documentation for the create_aip_replicas management
command.
@tw4l tw4l force-pushed the dev/issue-1440-offline-replica-space branch from bb24a8d to 8daf752 Compare July 19, 2021 15:05
@tw4l tw4l merged commit 8daf752 into 0.18 Jul 19, 2021
@tw4l tw4l deleted the dev/issue-1440-offline-replica-space branch July 19, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-mason sarah-mason sarah-mason approved these changes

@scollazo scollazo Awaiting requested review from scollazo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tw4l @sromkey @sarah-mason