Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding persian names of months and month-abbreviations and day-abbreviations in Gregorian calendar #1172

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

fouladi
Copy link
Contributor

@fouladi fouladi commented Apr 17, 2024

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

@krisfremen krisfremen self-requested a review June 23, 2024 05:54
@jadchaar
Copy link
Member

@fouladi would it be possible to add some unit tests? Then we can merge this in.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (403c29f) to head (cd6db81).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2324      2324           
  Branches       357       357           
=========================================
  Hits          2324      2324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you added the + signs? These are unnecessary. Mind removing them in a revision so we can merge these changes in?

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once plus signs are removed and unit tests are added we can merge.

@jadchaar jadchaar merged commit 016fb9e into arrow-py:master Oct 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants