Resume K8s integration tests #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t scope to functional test modules, as required after the split of such artifacts in the Fabri8 Kubernetes client project
…t Accept header for the HTTP call that verifies the version
…am-Protocol-Version header
… to use the correct ones, i.e. apps/replicasets
… .metadata.annotations in a Service resource and avoid NPE, when creatiing an URL for the service itself
fabiobrz
force-pushed
the
issues-1313.resume-k8s-it
branch
2 times, most recently
from
ec9699d
to
064fafe
Compare
…fix imports plus expected body contentsin HelloWorldIT
fabiobrz
force-pushed
the
issues-1313.resume-k8s-it
branch
8 times, most recently
from
6578487
to
e2b0ccb
Compare
fabiobrz
force-pushed
the
issues-1313.resume-k8s-it
branch
from
e2b0ccb
to
05bb397
Compare
fabiobrz
force-pushed
the
issues-1313.resume-k8s-it
branch
from
05bb397
to
e0e477c
Compare
jimma
reviewed
Sep 27, 2024
| @@ -25,6 +25,11 @@ | |||
| <artifactId>junit</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.fabric8</groupId> | |||
There was a problem hiding this comment.
Just some minor thing. Can we add this dependency under kubernetes/pom.xml instead of adding to each sub modules ?
There was a problem hiding this comment.
@jimma the dependency is needed by 5 out of 9 child projects, and we don't really want for others that don't need it to inherit it, e.g.: the istio module should not depend on this artifact as they don't need it. The dependency management is already defined by the root POM, so in the end I don't think we should bring it up.
Do you agree?
jimma
approved these changes
Sep 27, 2024
|
I am merging this, based on the approval and related discussion with @jimma about the pending comment, which has been agreed upon to be marked as resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Changes aim at resuming Arquillian Cube tests for Kubernetes integration.
Changes proposed in this pull request:
Fixes #1313