Merge branch 'codeql' into alert-autofix-41

arpitjain099 · Oct 20, 2024 · f847274 · f847274
2 parents 178266e + 6c416f5
commit f847274
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/End_to_end_Solutions/AOAISearchDemo/app/data/app.py b/End_to_end_Solutions/AOAISearchDemo/app/data/app.py
@@ -205,8 +205,8 @@ def get_user_profile(user_id: str):
         else:
             return Response(response=json.dumps(user_profile.to_item()), status=200)
     except Exception as e:
-        logger.exception(f"get-user-profile: error: {e}")
-        return Response(response="An internal server error occurred.", status=500)
+        logging.error("An error occurred while fetching user profile: %s", e, exc_info=True)
+        return Response(response="An internal error has occurred.", status=500)
 
 @app.route('/user-profiles', methods=['GET'])
 def get_all_user_profiles():
@@ -215,8 +215,8 @@ def get_all_user_profiles():
         json_user_profiles = [user_profile.to_item() for user_profile in user_profiles]
         return Response(response=json.dumps(json_user_profiles), status=200)
     except Exception as e:
-        logger.exception(f"get-all-user-profiles: error: {e}")
-        return Response(response="An internal server error occurred.", status=500)
+        logging.error("An error occurred while fetching all user profiles: %s", e, exc_info=True)
+        return Response(response="An internal error has occurred.", status=500)
 
 @app.route('/user-groups/<group_id>', methods=['POST'])
 def create_user_group(group_id: str):
@@ -240,7 +240,8 @@ def create_user_group(group_id: str):
     except CosmosConflictError as e:
         return Response(response=str(e), status=409)
     except Exception as e:
-        return Response(response=str(e), status=500)
+        logging.error("An error occurred while creating user group: %s", e, exc_info=True)
+        return Response(response="An internal error has occurred.", status=500)
 
 @app.route('/user-groups/<group_id>', methods=['GET'])
 def get_user_group(group_id: str):
@@ -283,7 +284,8 @@ def update_user_group(group_id: str):
         user_group = entities_manager.add_users_to_user_group(group_id, new_users)
         return Response(response=json.dumps(user_group.to_item()), status=200)
     except (TypeError, NullValueError, MissingPropertyError, ValueError) as e:
-        return Response(response=str(e), status=400)
+        logging.error("An error occurred while updating user group: %s", e, exc_info=True)
+        return Response(response="An internal error has occurred.", status=400)
     except SessionNotFoundError as e:
         logging.error("Session not found: %s", e, exc_info=True)
         return Response(response="Session not found.", status=404)