-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Android #13
base: master
Are you sure you want to change the base?
support Android #13
Conversation
This is great! Thanks for the PR -- a lot of people |
:D Could you please merge the request? |
I've had a chance to quickly review the PR. I'd like to see a few changes:
Do you think you could take implement any of these requests such that both iOS and Android implementations support the same features? Thank you again for your work. |
I'm on RN 0.32 and your module gives me "Cannot call upload of undefined" because NativeModules.FileTransfer does not exist. Your module seems to depend on NativeModules.FileTransfer, but this does not exist for me (I console.log it out and it's NULL) |
Hi @GeoffreyPlitt -- I'll take a look with a current version of RN next week. Can you post a separate issue please? |
Will do |
+1 |
1 similar comment
+1 |
Add support for RNUploaderProgress
+1 and I'd be happy to do the necessary updates. Would you merge a suitable version? |
Can we follow same name spacing between android and ios implementation? |
I would also add a JS interface to hide the awkward DeviceEmitter stuff that needs to go into code. So the API would be exactly the same in iOS and Android. |
Anyone still working on this? |
I got error on sync gradle |
@aroth will this lib ever support android? it looks like this PR has been abandoned |
No description provided.