Clean tests

arnaud-lb · Oct 24, 2024 · 962ef27 · 962ef27
1 parent 9f0cc2c
commit 962ef27
Show file tree

Hide file tree

Showing 21 changed files with 24 additions and 68 deletions.
diff --git a/package.xml b/package.xml
@@ -145,7 +145,6 @@
     <file role="test" name="produce_consume.phpt"/>
     <file role="test" name="produce_consume_queue.phpt"/>
     <file role="test" name="produce_consume_transactional.phpt"/>
-    <file role="test" name="produce_opaque_noconf.phpt"/>
     <file role="test" name="produce_opaque_noflush_dr_callback.phpt"/>
     <file role="test" name="produce_opaque_noflush.phpt"/>
     <file role="test" name="produce_opaque.phpt"/>

diff --git a/tests/bug115.phpt b/tests/bug115.phpt
@@ -10,7 +10,7 @@ require __DIR__ . '/integration-tests-check.php';
 $delivered = 0;
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->setErrorCb(function ($producer, $err, $errstr) {

diff --git a/tests/bug465.phpt b/tests/bug465.phpt
@@ -18,7 +18,7 @@ var_dump($n > 0);
 
 function getTopics() {
     $conf = new RdKafka\Conf();
-    if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+    if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
         $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
     }
     $conf->set('metadata.broker.list', getenv('TEST_KAFKA_BROKERS'));

diff --git a/tests/conf_callbacks.phpt b/tests/conf_callbacks.phpt
@@ -1,8 +1,5 @@
 --TEST--
 RdKafka\Conf
---SKIPIF--
-<?php
-(RD_KAFKA_VERSION >= 0x090000 && RD_KAFKA_VERSION < 0x010100ff) || die("skip librdkafka too old");
 --FILE--
 <?php
 

diff --git a/tests/conf_callbacks_integration.phpt b/tests/conf_callbacks_integration.phpt
@@ -2,7 +2,6 @@
 RdKafka\Conf
 --SKIPIF--
 <?php
-RD_KAFKA_VERSION >= 0x090000 || die("skip librdkafka too old");
 (!isset($_ENV['TESTS_DONT_SKIP_RISKY']) || $_ENV['TESTS_DONT_SKIP_RISKY']) && die("skip Risky/broken test");
 require __DIR__ . '/integration-tests-check.php';
 --FILE--

diff --git a/tests/conf_callbacks_rdkafka11.phpt b/tests/conf_callbacks_rdkafka11.phpt
@@ -1,8 +1,5 @@
 --TEST--
 RdKafka\Conf
---SKIPIF--
-<?php
-RD_KAFKA_VERSION >= 0x010100ff || die("skip librdkafka too old");
 --FILE--
 <?php
 

diff --git a/tests/conf_setDefaultTopicConf.phpt b/tests/conf_setDefaultTopicConf.phpt
@@ -1,11 +1,5 @@
 --TEST--
 RdKafka\Conf::setDefaultTopicConf()
---SKIPIF--
-<?php
-if (!method_exists('RdKafka\Conf', 'setDefaultTopicConf') || 7 < PHP_MAJOR_VERSION) {
-    echo "skip";
-}
-?>
 --FILE--
 <?php
 

diff --git a/tests/controller_id.phpt b/tests/controller_id.phpt
@@ -3,7 +3,7 @@ Display controller id
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_BUILD_VERSION < 0x010000ff && die("skip librdkafka < 1.0.0");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
@@ -22,4 +22,4 @@ echo (new RdKafka\KafkaConsumer($conf))->getControllerId(10*1000) . \PHP_EOL;
 --EXPECT--
 1
 1
-1
+1
diff --git a/tests/init_transaction_not_configured.phpt b/tests/init_transaction_not_configured.phpt
@@ -11,7 +11,7 @@ if (!class_exists("RdKafka\\KafkaErrorException")) {
 require __DIR__ . '/integration-tests-check.php';
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 

diff --git a/tests/message_headers.phpt b/tests/message_headers.phpt
@@ -2,8 +2,8 @@
 Message headers
 --SKIPIF--
 <?php
-RD_KAFKA_VERSION >= 0x000b04ff || die("skip librdkafka too old");
 require __DIR__ . '/integration-tests-check.php';
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';

diff --git a/tests/oauthbearer_integration.phpt b/tests/oauthbearer_integration.phpt
@@ -3,7 +3,7 @@ Oauthbearer
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_VERSION >= 0x01010000 || die("skip librdkafka too old does not support oauthbearer");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
@@ -37,7 +37,7 @@ function generateJws($scope = 'required-scope', $expiresInSeconds = 60)
 
 // Set up tests
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->set('metadata.broker.list', getenv('TEST_KAFKA_OAUTH_BROKERS'));

diff --git a/tests/produce_consume.phpt b/tests/produce_consume.phpt
@@ -10,7 +10,7 @@ require __DIR__ . '/integration-tests-check.php';
 $delivered = 0;
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->setErrorCb(function ($producer, $err, $errstr) {

diff --git a/tests/produce_consume_queue.phpt b/tests/produce_consume_queue.phpt
@@ -10,7 +10,7 @@ require __DIR__ . '/integration-tests-check.php';
 $delivered = 0;
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->setErrorCb(function ($producer, $err, $errstr) {
@@ -54,7 +54,7 @@ printf("%d messages delivered\n", $delivered);
 $conf = new RdKafka\Conf();
 // Required to detect actual reaching of partition EOF for both topics
 $conf->set('enable.partition.eof', 'true');
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->setErrorCb(function ($producer, $err, $errstr) {

diff --git a/tests/produce_consume_transactional.phpt b/tests/produce_consume_transactional.phpt
@@ -14,7 +14,7 @@ $delivered = 0;
 
 $conf = new RdKafka\Conf();
 $conf->set('transactional.id', 'transactional-producer');
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->setLogCb(function ($kafka, $level, $facility, $message) {});

diff --git a/tests/produce_opaque.phpt b/tests/produce_opaque.phpt
@@ -3,13 +3,13 @@ Produce with opaque
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_BUILD_VERSION < 0x1000000 && die("skip librdkafka < 1.0.0");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->set('metadata.broker.list', getenv('TEST_KAFKA_BROKERS'));

diff --git a/tests/produce_opaque_noconf.phpt b/tests/produce_opaque_noconf.phpt
diff --git a/tests/produce_opaque_noflush.phpt b/tests/produce_opaque_noflush.phpt
@@ -3,13 +3,13 @@ Produce with opaque, no flush
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_BUILD_VERSION < 0x1000000 && die("skip librdkafka < 1.0.0");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->set('metadata.broker.list', getenv('TEST_KAFKA_BROKERS'));

diff --git a/tests/produce_opaque_noflush_dr_callback.phpt b/tests/produce_opaque_noflush_dr_callback.phpt
@@ -3,13 +3,13 @@ Produce with opaque, no flush, with delivery callback
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_BUILD_VERSION < 0x1000000 && die("skip librdkafka < 1.0.0");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->set('metadata.broker.list', getenv('TEST_KAFKA_BROKERS'));

diff --git a/tests/produce_opaque_purge.phpt b/tests/produce_opaque_purge.phpt
@@ -3,13 +3,13 @@ Produce with opaque, purge queued/inflight messages
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_BUILD_VERSION < 0x1000000 && die("skip librdkafka < 1.0.0");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->set('metadata.broker.list', getenv('TEST_KAFKA_BROKERS'));

diff --git a/tests/produce_opaque_purge_dr_callback.phpt b/tests/produce_opaque_purge_dr_callback.phpt
@@ -3,13 +3,13 @@ Produce with opaque, purge queued/inflight messages, with delivery callback
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_BUILD_VERSION < 0x1000000 && die("skip librdkafka < 1.0.0");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->set('metadata.broker.list', getenv('TEST_KAFKA_BROKERS'));

diff --git a/tests/producev_opaque.phpt b/tests/producev_opaque.phpt
@@ -3,13 +3,13 @@ Producev with opaque
 --SKIPIF--
 <?php
 require __DIR__ . '/integration-tests-check.php';
-RD_KAFKA_BUILD_VERSION < 0x1000000 && die("skip librdkafka < 1.0.0");
+?>
 --FILE--
 <?php
 require __DIR__ . '/integration-tests-check.php';
 
 $conf = new RdKafka\Conf();
-if (RD_KAFKA_VERSION >= 0x090000 && false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
+if (false !== getenv('TEST_KAFKA_BROKER_VERSION')) {
     $conf->set('broker.version.fallback', getenv('TEST_KAFKA_BROKER_VERSION'));
 }
 $conf->set('metadata.broker.list', getenv('TEST_KAFKA_BROKERS'));