add aws connection method func

[refaelm92]

PR Type

enhancement

---

Description

• Introduced a new AWSConnectionMethod type to define AWS connection methods.
• Added constants CloudIAMRole and Credentials to specify connection methods.
• Implemented the GetConnectionMethod function in the AWSImageRegistry struct to determine the connection method based on the presence of RoleARN.

---

Changes walkthrough 📝

	Relevant files
Enhancement	registrymethods.go Add AWS connection method functionality                                    armotypes/registrymethods.go Added a new type AWSConnectionMethod to represent connection methods. Introduced constants CloudIAMRole and Credentials for connection methods. Implemented GetConnectionMethod function to determine the AWS connection method. +14/-0

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Validation Order The GetConnectionMethod function may be called before Validate(), which could lead to incorrect connection method determination if authentication data is missing Type Documentation The new AWSConnectionMethod type and its constants lack documentation comments explaining their purpose and usage

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Improve input validation to ensure credential pairs are complete when provided Add validation to ensure that both access key and secret key are provided together when using credentials authentication method. armotypes/registrymethods.go [85-87] -if (aws.AccessKeyID == "" || aws.SecretAccessKey == "") && aws.RoleARN == "" { - return errors.New("missing authentication data") +if aws.RoleARN == "" { + if aws.AccessKeyID == "" && aws.SecretAccessKey == "" { + return errors.New("missing authentication data") + } + if aws.AccessKeyID == "" || aws.SecretAccessKey == "" { + return errors.New("both access key and secret key must be provided") + } } Apply this suggestion Suggestion importance[1-10]: 9 Why: The suggestion significantly improves input validation by providing more specific error messages and ensuring both credentials are provided together, which prevents potential authentication issues.	9
General	Explicitly type constant values to ensure type safety and prevent potential reordering issues Add explicit type values to the constants to prevent potential issues if the constant order changes or new constants are added between them. armotypes/registrymethods.go [93-96] const ( - CloudIAMRole = iota - Credentials + CloudIAMRole AWSConnectionMethod = iota + Credentials AWSConnectionMethod = iota ) Apply this suggestion Suggestion importance[1-10]: 7 Why: Explicitly typing the constants with AWSConnectionMethod improves type safety and makes the code more maintainable, especially if more constants are added in the future.	7

💡 Need additional feedback ? start a PR chat