Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable oras pull to use system proxy #7227

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

IsMrX
Copy link
Contributor

@IsMrX IsMrX commented Sep 13, 2024

Description

If you encounter some network reasons that cause the download speed of resources on github and apt source stations to be very slow or fail, maybe we can use the system network proxy to solve it. The latest version supports the network proxy configured by the system environment variable HTTPS_PROXY. This commit solves the problem that the HTTPS_PROXY system network proxy configured by oras pull is not effective.

GitHub issue 7006

The issue mentioned that in some complex network environments, it may be necessary to mount a proxy to allow normal "apt install" and "oras pull". However, because oras pull uses "env", the HTTPS_PROXY system proxy we configured is invalid. Therefore, loading the original HTTPS_PROXY in "env" can solve the problem of slow "apt install" and slow "oras pull"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@IsMrX IsMrX requested a review from a team as a code owner September 13, 2024 12:04
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Sep 13, 2024
@igorpecovnik
Copy link
Member

@rpardini

Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine.
env was introduced because spurious vars set on host could make oras misbehave.
Here for full proxy support maybe NO_PROXY (?) would also be needed.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release labels Sep 13, 2024
@igorpecovnik igorpecovnik merged commit dfe8fc3 into armbian:main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants