Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-patch: generalize to-git functionality with PUSH_TO_GITHUB and PUSH_TO_REPO & enable for u-boot as well as kernel #6914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rpardini
Copy link
Member

@rpardini rpardini commented Jul 7, 2024

cli-patch: generalize to-git functionality with PUSH_TO_GITHUB and PUSH_TO_REPO & enable for u-boot as well as kernel

  • cli-patch: generalize to-git functionality with PUSH_TO_GITHUB and PUSH_TO_REPO & enable for u-boot as well as kernel
    • PUSH_TO_REPO=<url>: set the full git URL to push to
    • PUSH_TO_GITHUB=<org>/<repo>: shorthand for pushing to GitHub; sets PUSH_TO_REPO
    • note: be kind to GitHub, and use forks of torvalds/linux and u-boot/u-boot so GH has a decent base tree
      • still, kernel pushes are huge, mostly due to the all-wifi-drivers commit that's always first and always slightly different
    • note: when pushing to GitHub, keep in mind the pushed branch contains a GHA workflow, which will only run if you have GHA enabled on the repo
    • examples (adapt to your username/forks):
      • ./compile.sh BOARD=nanopct6 BRANCH=edge rewrite-kernel-patches PUSH_TO_GITHUB=rpardini/linux
      • ./compile.sh BOARD=rock-5b BRANCH=legacy rewrite-uboot-patches PUSH_TO_GITHUB=rpardini/armbian-patched-u-boot

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Framework Framework components labels Jul 7, 2024
@rpardini rpardini marked this pull request as ready for review July 7, 2024 22:07
@rpardini rpardini requested a review from a team as a code owner July 7, 2024 22:07
@ColorfulRhino ColorfulRhino added the Needs Documentation New feature needs documentation entry label Jul 7, 2024
@rpardini rpardini force-pushed the pr/cli-patch-generalize-to-git-functionality-with-PUSHTOGITHUB-and-PUSHTOREPO--enable-for-u-boot-as-well-as-kernel branch 4 times, most recently from 2689e56 to f54df58 Compare July 10, 2024 10:47
@rpardini rpardini force-pushed the pr/cli-patch-generalize-to-git-functionality-with-PUSHTOGITHUB-and-PUSHTOREPO--enable-for-u-boot-as-well-as-kernel branch 3 times, most recently from 89e2e7e to 058d204 Compare July 19, 2024 22:54
@rpardini rpardini requested a review from a team July 19, 2024 22:54
@rpardini rpardini force-pushed the pr/cli-patch-generalize-to-git-functionality-with-PUSHTOGITHUB-and-PUSHTOREPO--enable-for-u-boot-as-well-as-kernel branch 2 times, most recently from 463aaa4 to c2c4309 Compare July 22, 2024 17:00
@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress 08 Milestone: Third quarter release labels Jul 29, 2024
@igorpecovnik
Copy link
Member

From my perspective, few bits to documentation and its ready to merge.

@rpardini rpardini force-pushed the pr/cli-patch-generalize-to-git-functionality-with-PUSHTOGITHUB-and-PUSHTOREPO--enable-for-u-boot-as-well-as-kernel branch 2 times, most recently from 8e8e7ea to 023a862 Compare September 6, 2024 21:09
@rpardini rpardini removed the Work in progress Unfinished / work in progress label Sep 6, 2024
@rpardini rpardini force-pushed the pr/cli-patch-generalize-to-git-functionality-with-PUSHTOGITHUB-and-PUSHTOREPO--enable-for-u-boot-as-well-as-kernel branch from 023a862 to 9ad0cd4 Compare September 14, 2024 08:44
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review and removed 08 Milestone: Third quarter release labels Sep 14, 2024
…SH_TO_REPO & enable for u-boot as well as kernel

- `PUSH_TO_REPO=<url>`: set the full git URL to push to
- `PUSH_TO_GITHUB=<org>/<repo>`: shorthand for pushing to GitHub; sets `PUSH_TO_REPO`
- note: be kind to GitHub, and use forks of torvalds/linux and u-boot/u-boot so GH has a decent base tree
  - still, kernel pushes are huge, mostly due to the all-wifi-drivers commit that's always first and always slightly different
- note: when pushing to GitHub, keep in mind the pushed branch contains a GHA workflow, which will only run if you have GHA enabled on the repo
- examples (adapt to your username/forks):
  - `./compile.sh BOARD=nanopct6 BRANCH=edge rewrite-kernel-patches PUSH_TO_GITHUB=rpardini/linux`
  - `./compile.sh BOARD=rock-5b BRANCH=legacy rewrite-uboot-patches PUSH_TO_GITHUB=rpardini/armbian-patched-u-boot`
@rpardini rpardini force-pushed the pr/cli-patch-generalize-to-git-functionality-with-PUSHTOGITHUB-and-PUSHTOREPO--enable-for-u-boot-as-well-as-kernel branch from 9ad0cd4 to b4da0f0 Compare October 2, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Framework Framework components Needs Documentation New feature needs documentation entry Needs review Seeking for review size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

4 participants