Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic issues during in-circuit polynomial interpolation #148

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

winderica
Copy link
Contributor

Description

Currently, running EvaluationsVar::interpolate_and_evaluate during trusted setup (i.e., when the mode of cs is SynthesisMode::Setup) will panic, because the method internally obtains the value of an in-circuit variable by calling .value().unwrap(), but .value() always returns None during trusted setup.

This PR fixes this issue by replacing .value().unwrap() with .value().unwrap_or_default().


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests (N/A)
  • Updated relevant documentation in the code (N/A)
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@winderica winderica requested a review from a team as a code owner October 3, 2024 13:17
@winderica winderica requested review from z-tech, Pratyush and tyshko-rostyslav and removed request for a team October 3, 2024 13:17
@Pratyush Pratyush merged commit 8be4bfb into arkworks-rs:master Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants