Fix panic issues during in-circuit polynomial interpolation #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, running
EvaluationsVar::interpolate_and_evaluate
during trusted setup (i.e., when the mode ofcs
isSynthesisMode::Setup
) will panic, because the method internally obtains the value of an in-circuit variable by calling.value().unwrap()
, but.value()
always returnsNone
during trusted setup.This PR fixes this issue by replacing
.value().unwrap()
with.value().unwrap_or_default()
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer