Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Hashbrown to be optional #824

Closed
wants to merge 2 commits into from

Conversation

shamatar
Copy link
Contributor

@shamatar shamatar commented May 1, 2024

Description

Moves Hashbrown as optional dependency to allow compiling on systems without atomics. Long story short - unfortunately just making Hashbrown's ahash optional on the workspace will not solve everything as it removes HashMap::new() too, that is used in few places. Here is a variant that moves multivariate commits under feature flag, that were the only part that depends on the Hashbrown. At the moment benchmarks in poly part are broken as they depend on multivariate part. I believe it's possible to fix one way or another, just need to know which one.

Another option would be to try to make hash use explicit (and not use ahash), will be posted in alternative PR

Fixes #812

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@shamatar shamatar requested review from a team as code owners May 1, 2024 12:21
@shamatar shamatar requested review from z-tech, Pratyush and weikengchen and removed request for a team May 1, 2024 12:21
@shamatar shamatar mentioned this pull request May 1, 2024
6 tasks
@mmagician
Copy link
Member

closed by the alternative solution in #825

@mmagician mmagician closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ark-ec pulls in full hashbrown without feature gate
2 participants