Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves Hashbrown as optional dependency to allow compiling on systems without atomics. Long story short - unfortunately just making Hashbrown's
ahash
optional on the workspace will not solve everything as it removesHashMap::new()
too, that is used in few places. Here is a variant that moves multivariate commits under feature flag, that were the only part that depends on the Hashbrown. At the moment benchmarks inpoly
part are broken as they depend on multivariate part. I believe it's possible to fix one way or another, just need to know which one.Another option would be to try to make hash use explicit (and not use
ahash
), will be posted in alternative PRFixes #812
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer