Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks and improvements #104

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Minor tweaks and improvements #104

merged 2 commits into from
Aug 3, 2023

Conversation

chelma
Copy link
Collaborator

@chelma chelma commented Aug 3, 2023

Description

  • Tweaks help support OIDC and other non-default Auth options.
  • Added --force-bounce-capture and --force-bounce-viewer to config-update

Tasks

Testing

  • Added unit tests
  • Deployed using create-cluster
  • Tested force-bounce behavior against a cluster

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

* These tweaks help support OIDC and other non-default Auth
  options.

Signed-off-by: Chris Helma <[email protected]>
@chelma chelma requested a review from awick August 3, 2023 13:38
@chelma chelma changed the title Minor tweaks to Viewer and Viewer LB Minor tweaks and Improvements Aug 3, 2023
@chelma chelma changed the title Minor tweaks and Improvements Minor tweaks and improvements Aug 3, 2023
Copy link
Contributor

@awick awick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I know you don't love the viewer loop. Should we come up with a way to enable/disable that? Maybe lab vs prod mode if we do that in the future.

@chelma
Copy link
Collaborator Author

chelma commented Aug 3, 2023

LGTM, I know you don't love the viewer loop. Should we come up with a way to enable/disable that? Maybe lab vs prod mode if we do that in the future.

Ehhh... I'm coming around a bit on the loop. It's just a bit of a gotcha that needs to be planned around with things like special alarming rather than something I hate, per se. An alternative would be to leave the loop and add a CloudWatch alarm tied to a CloudWatch Logs Filter that looks for the process restart log statement. Let's see how it goes and circle back on that later.

@chelma chelma merged commit 3869628 into main Aug 3, 2023
@chelma chelma deleted the lb-tweaks branch August 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants