-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanilla #59
Conversation
When trying to build ssb-browser-demo with this, I get the following error:
|
Apparently I can get past that error by removing the "module" lines from:
However, then I run into this line which needs to be ported to the new singleton changes: EDIT: More complete path info in case it wasn't obvious. |
@KyleMaas this is WIP :) Was I was doing here is trying to get SSB browser core as close as possible to a normal ssb-server. This requires some more rework. I'm using this for a private group app I'm working on (not ready yet). |
No problem. I'm just excited about the idea of everything being closer to stock (well, probably more like changes upstreamed, but still) and think it might fix some of the problems with ssb-browser-demo not making it through a full sync if it can be made to work. |
This works now: Initial sync is really, really slow now. |
Yep, this is why we need partial replication using meta feeds. I have a few local changes to this branch I was working on yesterday. It needs some more fine tuning, but it makes SSB browser a lot closer to normal sbot. So in that regard it does require quite a few changes, but they are mostly search/replace. |
Yeah. I figure by getting ssb-browser-demo working, we have another way to test it with a decent UI. |
What should these calls be replaced with?
EDIT: Adding the reasons they're used in ssb-browser-demo. |
This needs to be updated to ssb-browser-core/simple-blobs.js Line 175 in eddd431
|
The feedreplication functions are removed. |
And with that last change to blobs, blobs now work in ssb-browser-demo again. Nice to have a nice easy way to test it. :) Profile and Public are updated to use Re: |
Finally have a bit of time to work on ssb-browser-demo but don't really want to do much until vanilla's merged since nearly everything I could do would cause conflicts. Any more progress on your end or is there anything I can do to help? |
Yesterday I found that this branch does not work when you start from scratch. It's a bit of a icky issue related to the singleton. I'm working on a solution. As for browser demo, I'd really like other clients to support meta feeds for initial sync to be decent speed and that is still quite a way into the future. Next year realisticly. |
Dagnabbit...I guess I'll work on something else, then. Thanks! |
Latest change should fix initialization with an empty database. I would be grateful if you have a look @KyleMaas. It works for me locally. |
Maybe I'm not patient enough with the sync, but I'm not seeing much difference. Without the |
Getting these after leaving it for a while:
|
It does seem to have finished syncing - latest message shown in Public is now <10 minutes ago. |
I don't expect browser-demo to use this v13, but I'll release a project tomorrow that uses this. It's a major version bump so one can always keep using the existing version. |
TODO: