add mockable executor #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a layer over os.exec that makes it possible to write testable code that doesn't run actual commands. The common executor interface is acompanied by two implementations, on that runs the commands normally (as the previous code did), and a "Dry Run" executor that keeps track of what would be executed. This enables us to have a "dry-run" mode that instead of executing the commands writes down what would be run, making it easy to run the same commands by hand when debugging. See the unit tests for more details.
aajith-arista
approved these changes
Dec 27, 2024
| } | ||
|
|
||
| // Join strings in a way that preserves the shell token boundries. For instance | ||
| // the args ["cat", "a file"] when simpy joined with strings. Join would result |
There was a problem hiding this comment.
typos:
simpy -> simply
strings. Join -> strings.Join
| } | ||
|
|
||
| func (ex *DryRunExecutor) GenerateShellScript() string { | ||
| preambule := "#!/usr/bin/env sh\n" |
There was a problem hiding this comment.
typo: preambule -> preamble
| if dir == "" { | ||
| dir = "$PWD" | ||
| } | ||
| full_invocation := fmt.Sprintf("(cd '%s' && %s)", dir, escapedInvocation) |
There was a problem hiding this comment.
Shouldn't cwd be restored ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a layer over os.exec that makes it possible to write testable code that doesn't run actual commands. The common executor interface is acompanied by two implementations, on that runs the commands normally (as the previous code did), and a "Dry Run" executor that keeps track of what would be executed. This enables us to have a "dry-run" mode that instead of executing the commands writes down what would be run, making it easy to run the same commands by hand when debugging.
See the unit tests for more details.