Feat(eos_cli_config_gen): Add support for ip name server groups #4763

laxmikantchintakindi · 2024-11-26T13:00:27Z

Change Summary

Add support for ip name server groups

Related Issue(s)

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

There is no input variable for applying the ip name-server group to monitor connectivity via eos_cli_config_gen. Below contains the use cause example.

ip name-server group {name_server_group}
name-server vrf {name_server_vrf} {IP}

monitor connectivity
vrf {name_server_vrf}
interface set {set_name} {loopback_name}
description {description}
!
host {host_name}
url {url}
name-server group {name_server_group}

How to test

Checklist

User Checklist

N/A

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions · 2024-11-26T13:00:45Z

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4763
# Activate the virtual environment
source test-avd-pr-4763/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/eos_cli/ip-name-server-group#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/eos_cli/ip-name-server-group --force
# Optional: Install AVD examples
cd test-avd-pr-4763
ansible-playbook arista.avd.install_examples

gmuloc · 2024-11-27T10:12:59Z

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ip_name_servers.schema.yml

@@ -5,7 +5,7 @@
 # Line above is used by RedHat's YAML Schema vscode extension
 # Use Ctrl + Space to get suggestions for every field. Autocomplete will pop up after typing 2 letters.
 type: dict
-keys:
+$defs:


add default: default on the vrf to document what you are doing in the templates

Removed this defs and added all the keys in ip_name_server_groups schema with default vrf default.

I guess the reason for this (==removing the defs) was because we are not currently injecting default for ip name-servers ?

ok thanks

seems that default: default would make sense for the other one as well:

site3-leaf1(config-if-Et4)#ip name-server 1.1.1.1 site3-leaf1(config)#show run se name-ser ip name-server vrf MGMT 10.14.0.1 ip name-server vrf MGMT 192.168.17.1 ip name-server vrf default 1.1.1.1

but that would be a breaking change in terms of what we produce as the current template does not inject VRF default. so we can revisit this later.

Can you please open an issue to track this?

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2

...s/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ip_name_server_groups.yml

github-actions · 2024-12-02T08:38:08Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-12-02T10:01:20Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2

ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg

gmuloc · 2024-12-05T08:47:10Z

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2

+ Use of this source code is governed by the Apache License 2.0
+ that can be found in the LICENSE file.
+#}
+{% for name_server_group in ip_name_server_groups | arista.avd.natural_sort("name") %}


please add a documentation templates for ip name-server groups listing the servers inside

MaheshGSLAB · 2024-12-10T07:21:47Z

...s/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ip_name_server_groups.yml

+    name_servers:
+      - ip_address: 8.8.8.8
+        vrf: vrf1
+        priority: 0


please remove the test for priority 0

MaheshGSLAB · 2024-12-10T07:24:09Z

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ip_name_server_groups.schema.yml

+            keys:
+              ip_address:
+                type: str
+                required: true


since we have ip_address as primary key we may not need required as true

also we can have the same ip address in different vrf.

Removed primary_key

I don't think we are allowed to keep required yet, please check once.

Also, you can keep ip_address as primary key and use allow_duplicate in order to use same ip address.

MaheshGSLAB · 2024-12-10T07:31:26Z

...s/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ip_name_server_groups.yml

@@ -0,0 +1,33 @@
+---


rename the file to ip-name-server-groups

MaheshGSLAB · 2024-12-10T08:54:33Z

...s/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ip_name_server_groups.yml

+        priority: 3
+
+  - name: mynameserver0
+    ip_domain_list: domain-list1


you can improve the coverage by not defining ip_domain_list and dns_domain here. Add one more name server when just define dns_domain and do not define name_servers.

MaheshGSLAB · 2024-12-10T08:57:48Z

python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ip-name-server-groups.j2

+| IP Address | VRF | Priority |
+| ----------- | --- | -------- |


Suggested change

| IP Address | VRF | Priority |

| ----------- | --- | -------- |

| IP Address | VRF | Priority |

| ---------- | --- | -------- |

Vibhu-gslab · 2024-12-10T10:51:55Z

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ip_name_server_groups.schema.yml

+            keys:
+              ip_address:
+                type: str
+                required: true


I don't think we are allowed to keep required yet, please check once.

Vibhu-gslab · 2024-12-10T10:52:55Z

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ip_name_server_groups.schema.yml

+            keys:
+              ip_address:
+                type: str
+                required: true


Also, you can keep ip_address as primary key and use allow_duplicate in order to use same ip address.

Vibhu-gslab · 2024-12-10T11:18:05Z

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2

+{%         do all_server_groups.append(server) %}
+{%     endfor %}
+{%     for server in all_server_groups | arista.avd.natural_sort("ip_address") | arista.avd.natural_sort("vrf") | arista.avd.natural_sort("priority") %}
+{%         if server.priority_defined %}


No need of priority_defined you can just check if priority != 0

Vibhu-gslab · 2024-12-10T11:22:49Z

ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg

+   dns domain arista.avd.com
+   ip domain-list domain-list1


Can we give different values for dns domain and ip domain-list across list.

Vibhu-gslab · 2024-12-10T11:23:36Z

ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg

@@ -416,6 +416,27 @@ monitor server radius
   probe threshold failure 100
   probe method access-request username arista password 7 141600021F102B
 !
+ip name-server group mynameserver0


Have we verified config on cvp?

for more information, see https://pre-commit.ci

github-actions bot assigned laxmikantchintakindi Nov 26, 2024

github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 26, 2024

laxmikantchintakindi force-pushed the feat/eos_cli/ip-name-server-group branch 6 times, most recently from 13bff48 to 52d9f5a Compare November 26, 2024 15:07

gmuloc reviewed Nov 27, 2024

View reviewed changes

laxmikantchintakindi force-pushed the feat/eos_cli/ip-name-server-group branch from 3e14cbf to ae1ef81 Compare November 27, 2024 12:28

MaheshGSLAB reviewed Nov 29, 2024

View reviewed changes

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2 Outdated Show resolved Hide resolved

...s/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ip_name_server_groups.yml Outdated Show resolved Hide resolved

laxmikantchintakindi force-pushed the feat/eos_cli/ip-name-server-group branch 3 times, most recently from fd9d66f to 37daa62 Compare December 2, 2024 07:30

laxmikantchintakindi requested a review from MaheshGSLAB December 2, 2024 07:30

github-actions bot added the state: conflict PR with conflict label Dec 2, 2024

laxmikantchintakindi force-pushed the feat/eos_cli/ip-name-server-group branch from 3fa7b5e to 69ae148 Compare December 2, 2024 10:01

github-actions bot removed the state: conflict PR with conflict label Dec 2, 2024

Vibhu-gslab force-pushed the feat/eos_cli/ip-name-server-group branch from 69ae148 to f555179 Compare December 3, 2024 07:06

Vibhu-gslab reviewed Dec 3, 2024

View reviewed changes

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2 Show resolved Hide resolved

MaheshGSLAB reviewed Dec 3, 2024

View reviewed changes

ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg Outdated Show resolved Hide resolved

laxmikantchintakindi requested review from Vibhu-gslab and MaheshGSLAB December 5, 2024 05:50

laxmikantchintakindi marked this pull request as ready for review December 5, 2024 08:18

laxmikantchintakindi requested a review from a team as a code owner December 5, 2024 08:18

gmuloc requested changes Dec 5, 2024

View reviewed changes

laxmikantchintakindi marked this pull request as draft December 5, 2024 08:51

laxmikantchintakindi force-pushed the feat/eos_cli/ip-name-server-group branch 5 times, most recently from 29f42a2 to cabcd45 Compare December 9, 2024 05:53

MaheshGSLAB reviewed Dec 10, 2024

View reviewed changes

laxmikantchintakindi force-pushed the feat/eos_cli/ip-name-server-group branch from f773c16 to 706180d Compare December 10, 2024 09:13

Vibhu-gslab force-pushed the feat/eos_cli/ip-name-server-group branch from 706180d to 36830c4 Compare December 10, 2024 10:46

Vibhu-gslab reviewed Dec 10, 2024

View reviewed changes

Laxmikant Chintakindi and others added 12 commits December 10, 2024 21:09

Feat(eos_cli_config_gen): Add support for ip name server groups

c6c14cc

add default:default

6b4b0f6

Fixing the sequence of commands

a58b17d

[pre-commit.ci] auto fixes from pre-commit.com hooks

6c1e61d

for more information, see https://pre-commit.ci

update tests

b1cd6bd

Minor change in input

d91e7f6

Remove priority 0 if it priority is undefined

72f59a2

Minor fix

c7146a4

Update doc template

a778623

Rewording a condition in template

83c950a

Address comments

f2b167d

minor change in template and inputs

172a66d

laxmikantchintakindi force-pushed the feat/eos_cli/ip-name-server-group branch from 6209a56 to 172a66d Compare December 10, 2024 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(eos_cli_config_gen): Add support for ip name server groups #4763

Feat(eos_cli_config_gen): Add support for ip name server groups #4763

laxmikantchintakindi commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

gmuloc Nov 27, 2024

laxmikantchintakindi Nov 27, 2024

gmuloc Dec 5, 2024 •

edited

Loading

laxmikantchintakindi Dec 5, 2024

gmuloc Dec 5, 2024 •

edited

Loading

laxmikantchintakindi Dec 5, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

gmuloc Dec 5, 2024

laxmikantchintakindi Dec 9, 2024

MaheshGSLAB Dec 10, 2024

laxmikantchintakindi Dec 10, 2024

MaheshGSLAB Dec 10, 2024

MaheshGSLAB Dec 10, 2024

laxmikantchintakindi Dec 10, 2024

Vibhu-gslab Dec 10, 2024

Vibhu-gslab Dec 10, 2024

MaheshGSLAB Dec 10, 2024

laxmikantchintakindi Dec 10, 2024

MaheshGSLAB Dec 10, 2024

laxmikantchintakindi Dec 10, 2024

MaheshGSLAB Dec 10, 2024

laxmikantchintakindi Dec 10, 2024

Vibhu-gslab Dec 10, 2024

Vibhu-gslab Dec 10, 2024

Vibhu-gslab Dec 10, 2024

laxmikantchintakindi Dec 10, 2024

Vibhu-gslab Dec 10, 2024

laxmikantchintakindi Dec 10, 2024

Vibhu-gslab Dec 10, 2024

		\| IP Address \| VRF \| Priority \|
		\| ----------- \| --- \| -------- \|

Feat(eos_cli_config_gen): Add support for ip name server groups #4763

Are you sure you want to change the base?

Feat(eos_cli_config_gen): Add support for ip name server groups #4763

Conversation

laxmikantchintakindi commented Nov 26, 2024 • edited Loading

Change Summary

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

github-actions bot commented Nov 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmuloc Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmuloc Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laxmikantchintakindi commented Nov 26, 2024 •

edited

Loading

gmuloc Dec 5, 2024 •

edited

Loading

gmuloc Dec 5, 2024 •

edited

Loading