-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add support for ipv4/ipv6 access group ingress default in system.control_plane #4710
Feat(eos_cli_config_gen): Add support for ipv4/ipv6 access group ingress default in system.control_plane #4710
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4710
# Activate the virtual environment
source test-avd-pr-4710/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@ingress_1#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,ingress_1 --force
# Optional: Install AVD examples
cd test-avd-pr-4710
ansible-playbook arista.avd.install_examples |
48c5dbf
to
2164a1c
Compare
0a36b5a
to
8522c48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/system.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Show resolved
Hide resolved
…ess default in system.control_plane
716b95b
to
f643831
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Add support for ingress in system.control_plane
Related Issue(s)
Fixes #4467
Component(s) name
arista.avd.eos_cli_config_gen
How to test
CI
Checklist
Repository Checklist