build: introduce jscs checks infrastructure #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first attempt at introducing some coding guidelines (see #57) based on jscs checks. While playing with this PR it was clear that we don't have uniform coding guidelines at this point as most of jscs validations were failing ;-)
I'm sending this PR to start discussion on how to introduce stricter coding guidelines. One approach is to go over all the options and decide which ones we want to turn on. Other approach is to simply get coding style from the current aria templates and automate checks of those rules (probably a better way of moving forward, but even then we need to sync on PRs and introduce checks after merging all the PRs in progress).