Implemented the packaging of the plugin and cleaned a little. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the plugin/product is ready to be distributed through an Eclipse Update Site. For that I created both: - an Update Site project: to deliver the product - a Feature project: to put it in the update site (can't put plugins directly) Proper documentation has been added, especially as building the site has some quirks (with the basic tool one can't choose the export folder for instance). Note that the export of the site embeds an instance of the Node.js program. Grunt has also been added (along with npm package definition to do things well) in order to create a cleaning task, especially for the update site which gets generated locally. I also added the main project (Plugin project) files to version control, since it's in fact part of the project configuration and not a user preference. And honestly most people will use Eclipse to work on this project, since PDE (Plugin Development Environment) is easier to use through it. Finally, documentation has been updated, and things cleaned a little. Here are some other technical changes: - the Backend class has been refactored a lot, and a dedicated ProcessRunner class has been introduced (more powerful than the standard one). - added a grunt task to configure automatically the port used by the backend to match the one used in the plugin - changed this port arbitrary to 50000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the plugin/product is ready to be distributed through an Eclipse Update Site. For that I created both:
Proper documentation has been added, especially as building the site has some quirks (with the basic tool one can't choose the export folder for instance).
Note that the export of the site embeds an instance of the Node.js program.
Grunt has also been added (along with npm package definition to do things well) in order to create a cleaning task, especially for the update site which gets generated locally.
I also added the main project (Plugin project) files to version control, since it's in fact part of the project configuration and not a user preference. And honestly most people will use Eclipse to work on this project, since PDE (Plugin Development Environment) is easier to use through it.
Finally, documentation has been updated, and things cleaned a little.
Here are some other technical changes:
Implements most of #1 (except maybe a proper interaction with the backend regarding its initialization - like for the port number), and all of #16.