New options to better check Aria Templates dependencies. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies. atpackager is now able to compare the global variables used in a file with the dependencies declared in $dependencies and it can report differences (useless declared dependencies or undeclared used dependencies), displaying either warnings or errors.
|
This pull request is not yet ready to be integrated: in order to be really usable, there should be a way to mark that some specific accesses to global variables are normal, even if the corresponding dependencies are not present in the $dependencies section, so that the corresponding errors/warnings are removed. This is especially useful for dependencies loaded with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, atpackager is able to compare the global variables used in a file with the dependencies declared in $dependencies and it can report differences (useless declared dependencies or undeclared used dependencies), displaying either warnings or errors.