Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-workflows): fix clusterworkflowtemplates disabled flag #2033

Merged
merged 4 commits into from
May 10, 2023
Merged

fix(argo-workflows): fix clusterworkflowtemplates disabled flag #2033

merged 4 commits into from
May 10, 2023

Conversation

PidgeyBE
Copy link
Contributor

@PidgeyBE PidgeyBE commented May 8, 2023 •
edited by jmeridth
Loading

Fix for #1925

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@jmeridth
Copy link
Member

jmeridth commented May 9, 2023

Need to update Chart.yaml version and artifacthub annotations at bottom please.

@PidgeyBE
Copy link
Contributor Author

PidgeyBE commented May 9, 2023

@jmeridth I've updated artifacthub annotations and Chart version. But it's hard to keep up with the version changes 😬

yu-croco
yu-croco approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yu-croco yu-croco merged commit cc64b0c into argoproj:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-croco yu-croco yu-croco approved these changes

@jmeridth jmeridth jmeridth approved these changes

@vladlosev vladlosev Awaiting requested review from vladlosev vladlosev is a code owner

Assignees
No one assigned
Labels
argo-workflows size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PidgeyBE @jmeridth @yu-croco