Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add images to resources in sync result #20954

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+812 −722
Draft

feat: Add images to resources in sync result #20954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions assets/swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions controller/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,7 @@
HookPhase: res.HookPhase,
Status: res.Status,
Message: res.Message,
Images: res.Images,

Check failure on line 450 in controller/sync.go

View workflow job for this annotation

GitHub Actions / Build & cache Go code 

res.Images undefined (type "github.com/argoproj/gitops-engine/pkg/sync/common".ResourceSyncResult has no field or method Images)

Check failure on line 450 in controller/sync.go

View workflow job for this annotation

GitHub Actions / Check changes to generated code 

res.Images undefined (type "github.com/argoproj/gitops-engine/pkg/sync/common".ResourceSyncResult has no field or method Images)

Check failure on line 450 in controller/sync.go

View workflow job for this annotation

GitHub Actions / Lint Go code 

res.Images undefined (type "github.com/argoproj/gitops-engine/pkg/sync/common".ResourceSyncResult has no field or method Images)) (typecheck)

Check failure on line 450 in controller/sync.go

View workflow job for this annotation

GitHub Actions / Lint Go code 

res.Images undefined (type "github.com/argoproj/gitops-engine/pkg/sync/common".ResourceSyncResult has no field or method Images)) (typecheck)

Check failure on line 450 in controller/sync.go

View workflow job for this annotation

GitHub Actions / Lint Go code 

res.Images undefined (type "github.com/argoproj/gitops-engine/pkg/sync/common".ResourceSyncResult has no field or method Images)) (typecheck)

Check failure on line 450 in controller/sync.go

View workflow job for this annotation

GitHub Actions / Lint Go code 

res.Images undefined (type "github.com/argoproj/gitops-engine/pkg/sync/common".ResourceSyncResult has no field or method Images) (typecheck)
})
}

Expand Down
6 changes: 6 additions & 0 deletions manifests/core-install.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions manifests/crds/application-crd.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions manifests/ha/install.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions manifests/install.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1,488 changes: 768 additions & 720 deletions pkg/apis/application/v1alpha1/generated.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions pkg/apis/application/v1alpha1/generated.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/apis/application/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,6 +1456,8 @@ type ResourceResult struct {
HookPhase synccommon.OperationPhase `json:"hookPhase,omitempty" protobuf:"bytes,9,opt,name=hookPhase"`
// SyncPhase indicates the particular phase of the sync that this result was acquired in
SyncPhase synccommon.SyncPhase `json:"syncPhase,omitempty" protobuf:"bytes,10,opt,name=syncPhase"`
// Images contains the images related to the ResourceResult
Images []string `json:"images,omitempty" protobuf:"bytes,11,opt,name=images"`
}

// GroupVersionKind returns the GVK schema information for a given resource within a sync result
Expand Down
9 changes: 7 additions & 2 deletions pkg/apis/application/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading