Fix: Ensure ConfigMap and StatefulSet updates are applied during operator upgrades #1619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR fixes an issue where updates to the argocd-redis-ha-configmap, argocd-redis-ha-health-configmap, and the StatefulSet argocd-redis-ha-server were not being reflected during OpenShift GitOps operator upgrades.
The current code missed checking for changes in:
As a result, changes introduced in higher versions of the operator were not applied unless the config maps and StatefulSet were manually deleted or the .spec.ha.enabled field was toggled in the ArgoCD Custom Resource (CR). This PR ensures these changes are correctly detected and applied.
This PR:
Adds logic to check for changes in the argocd-redis-ha-configmap and argocd-redis-ha-health-configmap data fields during operator upgrades.
Includes validation for the env variables in the argocd-redis-ha-server StatefulSet to ensure updates are reflected.
Ensures that any required updates are applied automatically without manual intervention.
/kind bug
Steps to reproduce the issue: