feat: log k8s create/update/delete actions #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Pitman <[email protected]>
Signed-off-by: John Pitman <[email protected]>
jopit
force-pushed
the
gitops-5878-log-k8s-actions
branch
from
a83c253 to
145a450
Compare
jgwest
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Looks great, thanks @jopit! And thanks for going through all the code and adding all these statements, I appreciate it as it was likely both somewhat monotonous work 😄, but also a case where its important to get the details right (and that combination can be deadly!)
I'm definitely looking forward to these changes making it into product code, as it should make working with user/customer operator logs much easier.
Everything looks great, just one suggestion around checking for nil on the logged object then good to go.
Signed-off-by: John Pitman <[email protected]>
jgwest
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Logs Create/Update/Deletion actions performed by Argo CD operator