feat: make specifying config-management sidecar plugin image optional #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwest
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Looks great, thanks @jopit!
Two quick requests:
- Can you add a short description of the new behaviour to
docs/usage/config_management_2.0.md? This looks like the best place to document the change in the code itself. - Can you likewise add a short description of the behaviour as a comment to
SidecarContainersfield in(and also the v1alpha1 API).argocd-operator/api/v1beta1/argocd_types.go
Line 113 in 9174e68
(I presume we will ALSO be documenting this downstream, but it couldn't hurt to briefly include it here too.)
|
Fixes #923 |
The description should actually be added to the argocd-operator/api/v1beta1/argocd_types.go Line 549 in 01c8ec9 |
Signed-off-by: John Pitman <[email protected]>
Signed-off-by: John Pitman <[email protected]>
jopit
force-pushed
the
gitops-5879-sidecar-default-image
branch
from
d66e6db to
c437afb
Compare
Signed-off-by: John Pitman <[email protected]>
Signed-off-by: John Pitman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Make specifying the sidecar image for a config-management plugin optional. When the image is not specified the operator will use the product image being used for the repo server.